[Backport 2.x] Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch-project#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <[email protected]> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh <[email protected]> (cherry picked from commit 62b7b4f)
Codecov Report
@@ Coverage Diff @@
## 2.x #811 +/- ##
=========================================
Coverage 66.45% 66.45%
Complexity 263 263
=========================================
Files 39 39
Lines 1717 1717
Branches 165 165
=========================================
Hits 1141 1141
Misses 453 453
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. |
Noir01
changed the title
gaobinlong
approved these changes
Nov 3, 2023
Hailong-am
reviewed
Nov 3, 2023
| @@ -142,6 +142,8 @@ dependencies { | |||
| implementation "com.amazonaws:aws-java-sdk-ses:${aws_version}" | |||
| implementation "com.sun.mail:javax.mail:1.6.2" | |||
| implementation "javax.activation:activation:1.1" | |||
| implementation "org.slf4j:slf4j-api:${versions.slf4j}" //Needed for httpclient5 | |||
| implementation "org.apache.logging.log4j:log4j-slf4j-impl:${versions.log4j}" | |||
| testImplementation( | |||
There was a problem hiding this comment.
do we need backport 2.x? this is need for httpclient 5, 2.x branch still using 4.x
There was a problem hiding this comment.
By my test, the error log of log4j really not seen in 2.x version, will close this backport PR, thanks!
|
Thanks @Noir01 , I will close this backport PR because it's not needed. |
|
Alrighty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aniruddh [email protected]
(cherry picked from commit 62b7b4f)
Description
Fixes warning message shown when sending test message
Issues Resolved
fixes #693
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.